Introduced AAP server in SRE plugins#10
Merged
Merged
Conversation
dmartinol
commented
Feb 24, 2026
dmartinol
commented
Collaborator
- Updated the pack card title to prioritize displaying the plugin title, followed by the plugin name and pack name.
- Enhanced the search functionality to include searching by plugin title in addition to name, description, skills, and agents.
- Introduced a new JSON file for plugin titles to improve consistency and clarity in the UI.
- Added a new section in the pack details modal to display the plugin name if it differs from the title, improving user awareness of plugin identity.
- Updated the pack card title to prioritize displaying the plugin title, followed by the plugin name and pack name. - Enhanced the search functionality to include searching by plugin title in addition to name, description, skills, and agents. - Introduced a new JSON file for plugin titles to improve consistency and clarity in the UI. - Added a new section in the pack details modal to display the plugin name if it differs from the title, improving user awareness of plugin identity. Signed-off-by: Daniele Martinoli <dmartino@redhat.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request adds plugin title support to differentiate between technical plugin identifiers and user-friendly display names, along with significant AAP (Ansible Automation Platform) integration enhancements for the SRE collection. Despite the title suggesting focus on "AAP server in SRE plugins," the changes encompass much broader functionality.
Changes:
- Introduced a
docs/plugins.jsonfile to centrally manage user-friendly plugin titles separate from technical plugin names - Updated plugin.json files to use kebab-case identifiers (e.g.,
rh-sre) while displaying human-readable titles in the UI - Enhanced the web UI to prioritize displaying plugin titles over names, with search functionality updated to include title-based searches
- Updated AAP MCP server configuration URL pattern (though with inconsistencies in variable naming)
- Added extensive AAP integration documentation including test guides, playbook integration workflows, and job execution guides
- Significantly expanded skill documentation for playbook-generator, playbook-executor, and mcp-aap-validator to detail AAP-based workflows
Reviewed changes
Copilot reviewed 16 out of 16 changed files in this pull request and generated 11 comments.
Show a summary per file
| File | Description |
|---|---|
| scripts/generate_pack_data.py | Added plugin title loading from docs/plugins.json and logic to override plugin names with titles |
| docs/plugins.json | New file mapping plugin identifiers to display titles for all collections |
| rh-sre/.claude-plugin/plugin.json | Changed name from "Red Hat SRE Agentic Skills Collection" to "rh-sre" |
| rh-support-engineer/.claude-plugin/plugin.json | Changed name from "Red Hat Support Engineer Agentic Collection" to "rh-support-engineer" |
| rh-virt/.claude-plugin/plugin.json | Changed name from "OpenShift Virtualization Agentic Collection" to "rh-virt" |
| ocp-admin/.claude-plugin/plugin.json | Changed name from "OpenShift Administration Agentic Skills Collection" to "rh-ocp-admin" |
| docs/app.js | Updated UI to display plugin titles, enhanced search to include titles, added plugin name display in modals when different from title |
| rh-sre/.mcp.json | Updated AAP MCP server URLs to use AAP_MCP_SERVER variable |
| rh-sre/skills/playbook-generator/SKILL.md | Added critical warnings about scope limitation (generation only, not execution) and AAP integration details |
| rh-sre/skills/playbook-executor/SKILL.md | Completely rewritten to describe AAP-based execution workflow with dry-run, monitoring, and comprehensive reporting |
| rh-sre/skills/mcp-aap-validator/SKILL.md | Enhanced to validate AAP resources (job templates, inventories) in addition to connectivity |
| rh-sre/agents/remediator.md | Updated to emphasize proper skill invocation patterns and AAP execution workflow |
| rh-sre/docs/testing/aap-integration-test-guide.md | New comprehensive test guide for AAP integration (649 lines) |
| rh-sre/docs/ansible/playbook-integration-aap.md | New guide for Git-based playbook integration with AAP (667 lines) |
| rh-sre/docs/ansible/aap-job-execution.md | New guide for AAP job execution patterns and troubleshooting (532 lines) |
| rh-sre/README.md | Updated playbook-executor description to mention AAP capabilities |
Comments suppressed due to low confidence (1)
docs/app.js:371
- Potential null/undefined access issue in search: The search functionality accesses
pack.plugin.name,pack.plugin.title, andpack.plugin.descriptionwithout null-checkingpack.plugin. If any pack doesn't have a plugin object, this will throw an error. Consider adding null-safe access or filtering out null values:
const searchText = [
pack.name,
pack.plugin?.name,
pack.plugin?.title,
pack.plugin?.description,
...pack.skills.map(s => s.name + ' ' + s.description),
...pack.agents.map(a => a.name + ' ' + a.description)
].filter(Boolean).join(' ').toLowerCase(); const searchText = [
pack.name,
pack.plugin.name,
pack.plugin.title,
pack.plugin.description,
...pack.skills.map(s => s.name + ' ' + s.description),
...pack.agents.map(a => a.name + ' ' + a.description)
].join(' ').toLowerCase();
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Changed environment variable references from `AAP_SERVER` to `AAP_MCP_SERVER`. - Added a new skill, `job-template-remediation-validator`, to validate AAP job templates for CVE remediation playbooks. - Enhanced existing skills and documentation to reflect the new validation process. Signed-off-by: Daniele Martinoli <dmartino@redhat.com>
r2dedios
reviewed
Feb 26, 2026
…alidation script Signed-off-by: r2dedios <alex.ansi.c@gmail.com>
…Linter Signed-off-by: r2dedios <alex.ansi.c@gmail.com>
Signed-off-by: r2dedios <alex.ansi.c@gmail.com>
Signed-off-by: r2dedios <alex.ansi.c@gmail.com>
Signed-off-by: r2dedios <alex.ansi.c@gmail.com>
…ATTERNS.md files and updated skill validation scripts Signed-off-by: r2dedios <alex.ansi.c@gmail.com>
- Added a note about the `limit` parameter being incorrectly serialized as `limit_` by some MCP clients, causing validation errors. - Updated documentation for `vulnerability__get_cves` and `mcp-lightspeed-validator` to reflect the workaround of omitting the `limit` parameter during connectivity tests. - Enhanced the `lightspeed-mcp-parameters` documentation to include details on handling the `limit` parameter correctly. Signed-off-by: [Your Name] [Your Email] Signed-off-by: Daniele Martinoli <dmartino@redhat.com>
…PRINCIPLES.md - CLAUDE.md: Keep single Skill and Agent Requirements heading; add Adding an Agent section from upstream; combine orchestration phrasing (skills + agents) - SKILL_DESIGN_PRINCIPLES.md: Keep remediation skill references, Skill-to-Skill Invocation Standard, Color Values table; use remediation skill (not remediator agent); preserve section numbering Made-with: Cursor
Signed-off-by: Daniele Martinoli <dmartino@redhat.com>
…h to handle user-passed paths correctly Signed-off-by: Daniele Martinoli <dmartino@redhat.com>
…or text files Signed-off-by: Daniele Martinoli <dmartino@redhat.com>
…tion in validate-skill.sh - Updated frontmatter opening and closing delimiter checks to avoid broken pipe issues. - Enhanced ASCII art detection logic to ensure proper handling of input without early exits. - Refined persona statement detection to improve linting accuracy. Signed-off-by: Daniele Martinoli <dmartino@redhat.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…n timestamps across multiple files, ensuring all references are current as of 2026-02-24. Signed-off-by: Daniele Martinoli <dmartino@redhat.com>
… server requirements - Revised descriptions for AAP job execution, emphasizing the use of job_templates_launch_retrieve and Git Flow processes. - Updated notes to specify the need for configured AAP MCP servers and pre-created job templates. - Improved clarity in the remediation verifier workflow by renaming steps for better understanding. Signed-off-by: [Your Name] [Your Email] Signed-off-by: Daniele Martinoli <dmartino@redhat.com>
Signed-off-by: Daniele Martinoli <dmartino@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.